Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsoncpp: disable object library #22436

Merged
merged 1 commit into from
Nov 10, 2024
Merged

jsoncpp: disable object library #22436

merged 1 commit into from
Nov 10, 2024

Conversation

raedrizqie
Copy link
Contributor

@raedrizqie raedrizqie commented Nov 7, 2024 •
edited
Loading

  • disable object library
  • install license file

@lazka
Copy link
Member

lazka commented Nov 8, 2024 •
edited
Loading

just wondering, does that simple rename work for cmake users?

@raedrizqie
Copy link
Contributor Author

ah.. i forgot about cmake compatibility (i was just considering pkgconfig pc file)

i think we need to fix this in cmake itself then

@lazka lazka marked this pull request as draft November 9, 2024 16:40
@raedrizqie
jsoncpp: disable object library
b9af1e4 
- disable object library
- install license file
@raedrizqie
Copy link
Contributor Author

i have reverted the static lib name change

@raedrizqie raedrizqie marked this pull request as ready for review November 10, 2024 05:23
@lazka lazka merged commit f85efa5 into msys2:master Nov 10, 2024
8 checks passed
@raedrizqie raedrizqie deleted the jsoncpp branch November 10, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raedrizqie @lazka