Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libp11 #22589

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add libp11 #22589

wants to merge 3 commits into from

Conversation

mlt
Copy link

@mlt mlt commented Nov 19, 2024

No description provided.

We are installing into a different prefix than our depenencies are
during makepkg, so fix the pkg-config calls to relocate. This is in theory
correct for all platforms.

Since that kicks in our path conversion, disable it so the passed install
prefix isn't converted via MSYS2_ARG_CONV_EXCL.
@lazka
Copy link
Member

lazka commented Nov 22, 2024

OK with my changes?

(we can always improve things later if needed)

@mlt
Copy link
Author

mlt commented Nov 22, 2024

Good catches! I should probably clean up the readme as well (at least the last paragraph). I was hesitating if it belongs there, but I think it might be helpful on how to configure things.

I took quite a detour trying to figuring out how to make things work on Windows with PATHs & escaping in configs, MSVC vs gcc, token/object names with vendor module vs emulated, etc. It took some time with Procmon. Then I realized that everything normally is going through p11-kit on all platforms and should be on Windows as well to unify configuration and minimize that for end apps. I even have opensc package for msys2 but I believe it is deadborn for 2 reasons: 1) the official installer and pkcs11 module work fine as is (no need to bring extra DLLs on PATH like with ykcs11), 2) we can't build minidriver anyway as it requires Cryptographic Provider Development Kit. So unless you encourage to submit a PR, I'd bury it.

@lazka
Copy link
Member

lazka commented Nov 23, 2024

I don't really know anything about these projects, so I can't really say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants