-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gr: Use Ninja, fix version generation. #8025
Conversation
Manually generate version number otherwise CMake fails for not being git repository.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
echo "${pkgver}" > version.txt | ||
|
||
# Remove invalid C++ compiler option | ||
sed -e "s|-Werror=implicit||g" -i CMakeLists.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you report this to upstream?
https://github.com/sciapp/gr/issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compiler flag support detection should be fixed now, so that CMakeLists.txt won't assume that all GCC and Clang versions support this flag.
Biswa96 has the right to report. |
@lazka ready to merge. |
Manually generate version number otherwise CMake fails for not being git repository.