Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gr: Use Ninja, fix version generation. #8025

Merged
merged 1 commit into from
Feb 28, 2021
Merged

gr: Use Ninja, fix version generation. #8025

merged 1 commit into from
Feb 28, 2021

Conversation

Biswa96
Copy link
Member

@Biswa96 Biswa96 commented Feb 27, 2021

Manually generate version number otherwise CMake fails for not being git repository.

Manually generate version number otherwise CMake fails for not being git repository.
@Biswa96
Copy link
Member Author

Biswa96 commented Feb 27, 2021

  1. Use Ninja for faster build.
  2. Create version.txt using pkgver variable. Otherwise, CMake shows this warning and pkgconfig files have zero version number.
CMake Warning at cmake/GetVersionFromGit.cmake:29 (message):
    Could not read version from git or version.txt
Call Stack (most recent call first):
    CMakeLists.txt:5 (get_version_from_git)
  1. Also remove the -Werror which shows warnings like these:
cc1plus.exe: warning: '-Werror=' argument '-Werror=implicit' is not valid for C++

/cc @kojix2 @kou Any opinions?

@kojix2
Copy link
Contributor

kojix2 commented Feb 27, 2021

@Biswa96
Awesome.
I can do simple things like updating the version number or updating the sha 256, but honestly, I don't know much about difficult things. I think @kou will take a look. It's good that the time required to build is reduced.
Thanks anyway!

Copy link
Contributor

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

echo "${pkgver}" > version.txt

# Remove invalid C++ compiler option
sed -e "s|-Werror=implicit||g" -i CMakeLists.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you report this to upstream?
https://github.com/sciapp/gr/issues

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compiler flag support detection should be fixed now, so that CMakeLists.txt won't assume that all GCC and Clang versions support this flag.

@kojix2
Copy link
Contributor

kojix2 commented Feb 27, 2021

Biswa96 has the right to report.
However, I think Biswa96 is just volunteering to help us this time, so I don't want to bother him.
I've posted a link to an existing issue on sciapp/gr.
But you can still report it as a new issue.

@Biswa96
Copy link
Member Author

Biswa96 commented Feb 28, 2021

@lazka ready to merge.

@lazka lazka merged commit 2707c30 into msys2:master Feb 28, 2021
@Biswa96 Biswa96 deleted the gr-use-ninja branch February 28, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants