Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mingw-w64 packages to commit 1c7738. #2425

Merged
merged 1 commit into from
Apr 11, 2021

Conversation

jeremyd2019
Copy link
Member

This should include fixes for msys2/CLANG-packages#6 and
msys2/CLANG-packages#21

@jeremyd2019
Copy link
Member Author

CI failed due to a blip cloning from sf's git server. But, CI fails anyway due to conflicts between the clang, ucrt, and 'normal' versions of the mingw-w64-cross packages, because the CI script installs all packages after building. If desired, I can split this into 3 pull requests that can each pass CI.

@Biswa96
Copy link
Member

Biswa96 commented Apr 7, 2021

Passing CI here would not make any difference. The can be merged as is because mingw-w64 toolchain will not fail to build 🤞

@jeremyd2019
Copy link
Member Author

Well, I've been doing some building with this revision, and ran into a regression in ucrt: https://sourceforge.net/p/mingw-w64/mailman/message/37257645/

Namely, fseterr.c from gnulib now fails to compile, because it tries to mess with the _flag field in the FILE*

This should include fixes for msys2/CLANG-packages#6,
msys2/CLANG-packages#21, and msys2/MINGW-packages#8310
@jeremyd2019 jeremyd2019 changed the title Update mingw-w64 packages to commit e37b31. Update mingw-w64 packages to commit 1c7738. Apr 9, 2021
@jeremyd2019
Copy link
Member Author

Issue I ran into is now fixed. PR updated to newer commit that fixes it.

@jeremyd2019
Copy link
Member Author

Once this is merged (or at least the mingw-w64-cross-clang packages, I can split them if that's more palatable) I intend to update/rebase #2294, and once that and #2426 are merged I can at least get msys2/CLANG-packages#2 building an aarch64 hosted and targeting clang in CI.

@lazka lazka merged commit 78c6dbe into msys2:master Apr 11, 2021
@lazka
Copy link
Member

lazka commented Apr 11, 2021

We need to move CI to use a temporary repository instead of installing everything in the PR.

@jeremyd2019 jeremyd2019 deleted the mingw-w64-update branch April 11, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants