Remove all modify functionality, rename binary #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Maintenance tool is now installed as 'Uninstall_MSYS2.exe' - 'Modify' button is disabled in Windows Settings 'Apps' list - Add/Remove and Modify choices are hidden on Introduction page, leaving 'Remove all components' as only available choice - Even though it's no longer accessible, the Repository configuration tab of the Settings dialog is also removed
lazka
reviewed
Apr 30, 2021
|
looks good! |
ferdnyc
commented
Apr 30, 2021
|
This repo was lacking a license, are you OK with https://spdx.org/licenses/BSD-3-Clause.html also for your changes? |
|
@lazka Absolutely, no objections. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the maintenance tool's misleading ability to reconfigure/update the installed components, restricting the features offered to the only one actually functional: Uninstalling MSYS2.
The maintenance tool is now installed as
Uninstall.exe, to make its purpose clearer:(Screenshot is out of date.)
The 'Modify' button is disabled in the Windows Settings 'Apps' list:
The Add/Remove and Modify choices are hidden on the Introduction page, leaving 'Remove all components' as the only available selection:
(Even though it's no longer accessible, the Repository configuration tab of the Settings dialog is also removed)