fix(error message): Clarify magic number mismatch error message between heap child information #118
Conversation
|
Sorry if this PR doesn't follow guidelines or should be submitted in another way. I couldn't find any documentation on this approach. Feel free to ignore if this isn't super useful, this is a tricky topic. |
There was a problem hiding this comment.
I'm not sure the added text really clarifies anything. The idea of searching and destroying alternate cygwin1.dll wouldn't help as the names are different with msys2, and the idea of doing that with msys-2.0.dll is also problematic because git-for-windows' version comes from a different fork, and anyway just deleting dlls is likely to break things worse. The best advice is just to not mix these environments, but I don't know how to word a message to that effect that would make sense.
winsup/cygwin/dcrt0.cc
Outdated
| @@ -1360,7 +1360,10 @@ multiple_cygwin_problem (const char *what, uintptr_t magic_version, uintptr_t ve | |||
| system_printf ("%s magic number mismatch detected - %p/%ly", what, magic_version, version); | |||
| else | |||
| api_fatal ("%s mismatch detected - %ly/%ly.\n\ | |||
| This problem is probably due to using incompatible versions of the cygwin DLL.\n\ | |||
| This problem is probably due to using incompatible versions of the msys2 or cygwin DLL.\n\ | |||
| msys2 is uses pinned memory to share child information. All versions running must be the same magic_version.\n\ | |||
There was a problem hiding this comment.
this was probably supposed to be either is using or just uses.
msys2 is a fork of cygwin but the error message for magic_versions is cygwin specific. Removing this message may remove a lot of documentation for users searching online. However, the documentation itself is not useful. Users will not find a cygwin version nor does the help online specify exact information. While cygwin was intended to be installed at a single location, msys2 is used in a variety of stand alone tools, one of which is git-for-windows. Whenever a version mismatch can occur this can lead to programs such as VS Code breaking other git installations, or vice-versa. In this regard a bit of a better error message can help people figure out what is wrong on thier msys2 or cygwin installed codebases.
|
Ok, I've updated this with more links as well as more verbose documentation about what cygwin recommends, versus what msys2 runtime may support. |
Quenty
force-pushed
the
users/quenty/fix_msys_error_message
branch
from
28eb9ef to
a548536
Compare
|
@lazka how do we want to proceed with regards to v3.4.2? |
I've been testing it for the last few days and I'm not aware of any issues. I'll prepare a PR. edit: msys2/MSYS2-packages#3409 |
we found another regression: https://cygwin.com/pipermail/cygwin/2022-December/252699.html |
msys2 is a fork of cygwin but the error message for magic_versions is cygwin specific. Removing this message may remove a lot of documentation for users searching online.
However, the documentation itself is not useful. Users will not find a cygwin version nor does the help online specify exact information. While cygwin was intended to be installed at a single location, msys2 is used in a variety of stand alone tools, one of which is git-for-windows. Whenever a version mismatch can occur this can lead to programs such as VS Code breaking other git installations, or vice-versa. In this regard a bit of a better error message can help people figure out what is wrong on their msys2 or cygwin installed codebases.
Docs PR:
msys2/msys2.github.io#235