Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start reverting some cygwin/msys renaming #218

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

lazka
Copy link
Member

@lazka lazka commented Jul 6, 2024

To reduce the diff to cygwin.

Just a handful of things, to get things started. See the commits for details.

lazka added 3 commits July 6, 2024 21:13
Rename all internal testing env vars back to start with CYGWIN_.
I've looked around and couldn't find any use of them, so I think it's
fine to just rename them back without anyone noticing.
Rename the docs installation dir back. There are various other things
called cygwin, so this doesn't add much.
Rename various log/errors messages back from msys to cygwin.
Copy link
Collaborator

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look good to me! And I agree that it makes sense to reduce the diff.

@lazka lazka merged commit 7484c55 into msys2:msys2-3.5.3 Jul 9, 2024
1 check passed
@lazka
Copy link
Member Author

lazka commented Jul 9, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants