Cygwin: revert use of CancelSyncronousIo on wait_thread. #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
approved these changes
Nov 22, 2024
|
This was a quick and dirty commit for testing, in response to msys2/MSYS2-packages#4340 (comment) - I fired up some tests to run while I slept, and they seem to not have hung on either x86_64 or ARM64, so I can come back to this and clean up the commit message and submit to cygwin-patches once approved here |
jeremyd2019
force-pushed
the
msys2-3.5.4-no-cancelsynchronousio
branch
from
d8ac68d to
d142cc5
Compare
It appears this is causing hangs on native x86_64 in similar scenarios as the hangs on ARM64, because `CancelSynchronousIo` is returning `TRUE` but not canceling the `ReadFile` call as expected. Addresses: msys2/MSYS2-packages#4340 (comment) Fixes: b091b47 ("cygthread: suspend thread before terminating.") Signed-off-by: Jeremy Drake <cygwin@jdrake.com>
jeremyd2019
force-pushed
the
msys2-3.5.4-no-cancelsynchronousio
branch
from
d142cc5 to
2eb6be1
Compare
dscho
added a commit
to dscho/MSYS2-packages
that referenced
this pull request
Nov 23, 2024
This change seems to have caused hangs on x86_64, so let's revert it. Addresses msys2#4340 (comment) and corresponds to msys2/msys2-runtime#243. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
lazka
pushed a commit
to msys2/MSYS2-packages
that referenced
this pull request
Nov 23, 2024
This change seems to have caused hangs on x86_64, so let's revert it. Addresses #4340 (comment) and corresponds to msys2/msys2-runtime#243. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
stahta01
pushed a commit
to stahta01/MSYS2-cygwin-packages
that referenced
this pull request
Dec 21, 2024
This change seems to have caused hangs on x86_64, so let's revert it. Addresses msys2/MSYS2-packages#4340 (comment) and corresponds to msys2/msys2-runtime#243. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears this is causing hangs on native x86_64 in similar scenarios
as the hangs on ARM64, because
CancelSynchronousIois returningTRUEbut not canceling the
ReadFilecall as expected.Addresses: msys2/MSYS2-packages#4340 (comment)
Fixes: b091b47 ("cygthread: suspend thread before terminating.")
created via
git checkout 16dfe943bcba396ac0b11c5b52cdbaeed4e03a8d -- sigproc.cc pinfo.cc