-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache installer in the toolcache #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove the Fixes #145
from the main message. This is an enhancement related to #145, but as we discussed there, we want to allow caching the packages and/or the whole installation locally; not only the installer.
5169e2d
to
7a4bdec
Compare
Unfortunately, this is not working as intended. It seems that the date is not passing the check of a valid semver, and causing the toolcache to not find any version. Stupid thing. |
@jeremyd2019 do you need a new release of this action (since #148 was merged)? |
Not personally. I've moved to using |
Some concern about caching the entire install, but this should at least save self-hosted runners having to download the installer every run.
Enhancement for #145