Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protect/2 for behaviors and implementations in the same module #51

Merged
merged 3 commits into from
Oct 7, 2020

Conversation

saneery
Copy link
Contributor

@saneery saneery commented Oct 2, 2020

👋
relates to #39

@saneery saneery force-pushed the behavior_implementation_same_module branch 2 times, most recently from 41a248c to 3ac6688 Compare October 3, 2020 07:31
@saneery saneery force-pushed the behavior_implementation_same_module branch from 3ac6688 to 2a6b06c Compare October 3, 2020 07:35
Copy link
Owner

@msz msz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, I've been meaning to do this for quite a long time! Just a couple small suggestions.

lib/hammox.ex Outdated Show resolved Hide resolved
lib/hammox.ex Outdated Show resolved Hide resolved
saneery and others added 2 commits October 6, 2020 10:29
Co-authored-by: Michał Szewczak <michal@szewczak.email>
Co-authored-by: Michał Szewczak <michal@szewczak.email>
@saneery
Copy link
Contributor Author

saneery commented Oct 8, 2020

@msz Could you add hactoberfest-accepted label here too? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants