Fix scope and internall error handling (#145)

mszostok · Apr 13, 2022 · 436c7ac · 436c7ac
1 parent 4e0aa9d
commit 436c7ac
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/internal/check/valid_owner.go b/internal/check/valid_owner.go
@@ -375,6 +375,7 @@ func (*ValidOwner) checkRequiredScopes(header http.Header) error {
 	gotScopes := strings.Split(header.Get(scopeHeader), ",")
 	presentScope := map[github.Scope]struct{}{}
 	for _, scope := range gotScopes {
+		scope = strings.TrimSpace(scope)
 		presentScope[github.Scope(scope)] = struct{}{}
 	}
 

diff --git a/internal/runner/runner_worker.go b/internal/runner/runner_worker.go
@@ -95,6 +95,10 @@ func (r *CheckRunner) collectMetrics(checkOut check.Output, err error) {
 		r.allFoundIssues[i.Severity]++
 	}
 
+	if err != nil {
+		r.allFoundIssues[check.Error]++
+	}
+
 	if len(checkOut.Issues) > 0 || err != nil {
 		r.notPassedChecksCnt++
 	}