Add a flag to only allow teams as owners #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
approved these changes
Mar 11, 2022
| @@ -186,6 +190,10 @@ func (v *ValidOwner) validateTeam(ctx context.Context, name string) *validateErr | |||
| } | |||
| } | |||
|
|
|||
| if !isGitHubTeam(name) { | |||
There was a problem hiding this comment.
nit: I could be moved before the v. orgTeams initialization.
| @@ -129,6 +129,7 @@ Use the following environment variables to configure the application: | |||
| | <tt>OWNER_CHECKER_REPOSITORY</tt> <b>*</b> | | The owner and repository name separated by slash. For example, gh-codeowners/codeowners-samples. Used to check if GitHub owner is in the given organization. | | |||
| | <tt>OWNER_CHECKER_IGNORED_OWNERS</tt> | `@ghost`| The comma-separated list of owners that should not be validated. Example: `"@owner1,@owner2,@org/team1,example@email.com"`. | | |||
| | <tt>OWNER_CHECKER_ALLOW_UNOWNED_PATTERNS</tt> | `true` | Specifies whether CODEOWNERS may have unowned files. For example: <br> <br> `/infra/oncall-rotator/ @sre-team` <br> `/infra/oncall-rotator/oncall-config.yml` <br> <br> The `/infra/oncall-rotator/oncall-config.yml` file is not owned by anyone. | | |||
| | <tt>OWNER_CHEKER_OWNERS_MUST_BE_TEAMS</tt> | `false` | Specifies whether only teams are allowed as owners of files | | |||
There was a problem hiding this comment.
nit:
Suggested change
| | <tt>OWNER_CHEKER_OWNERS_MUST_BE_TEAMS</tt> | `false` | Specifies whether only teams are allowed as owners of files | | |
| | <tt>OWNER_CHEKER_OWNERS_MUST_BE_TEAMS</tt> | `false` | Specifies whether only teams are allowed as owners of files. | |
Additionally, please add:
owner_cheker_owners_must_be_teams:
description: "Specifies whether only teams are allowed as owners of files."
default: "false"
required: falseto action.yml
There was a problem hiding this comment.
sadly, this is not documented in the readme https://github.com/mszostok/codeowners-validator#checks
There was a problem hiding this comment.
Thanks for letting me know, I will add it there too. For now, it was documented in configuration and in the release notes.
|
As there is no activity under this PR, I will merge it as it is and create a follow-up PR that will address missing parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mateusz!
I'd like to replace some horrible home-grown checkers with codeowners-validator. There's only one feature missing: in the repository I want to use this for, we require that all owners are teams.
This PR implements an optional addition to the owner checker to enforce this.