Add HTTP response disk cache #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the underlying library the "github.com/gregjones/httpcache" is used.
This implementation is heavily inspired by they Kubernetes approach for the kubectl.
By default, the cache will be saved in HOME dir under `.cdeowners-validator/cache/http/` folder. This can be changed by setting the `HTTP_CACHING_DIRECTORY="/tmp/cache"`
**Results:**
Checking the https://github.com/kyma-project/kyma repository:
- 1st run: `==> Executing Valid Owner Checker (16.366229522s)`
- 2nd run: `==> Executing Valid Owner Checker (844.978984ms)`
mszostok
force-pushed
the
add-http-cache
branch
from
aa40d20 to
832b500
Compare
|
Documentation needs to be added before merging |
mszostok
force-pushed
the
master
branch
2 times, most recently
from
1c4b010 to
1642c1e
Compare
mszostok
force-pushed
the
master
branch
13 times, most recently
from
f565722 to
4adb7be
Compare
|
turned out that currently it is not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implementation is heavily inspired by they Kubernetes approach for the kubectl.
By default, the cache will be saved in HOME dir under
.cdeowners-validator/cache/http/folder. This can be changed by setting theHTTP_CACHING_DIRECTORY="/tmp/cache"Results:
Checking the https://github.com/kyma-project/kyma repository:
==> Executing Valid Owner Checker (16.366229522s)==> Executing Valid Owner Checker (844.978984ms)