Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a get_keys() equivalent for lower than 5.7 Minetest versions #153

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

Athozus
Copy link
Member

@Athozus Athozus commented Aug 6, 2024

Fix #152

@MoNTE48 can you confirm me that it works ?

Notes :

  • It checks if get_keys() exists
  • Then, if not, it iterates through existing players (but consume more)
  • I've also reorganized into more functions to not have too much duplicates

@Athozus Athozus added Bug Something isn't working Release blocker No release until this is closed Cleanup Cleanup of bad code or other redundant/unnecessary stuff labels Aug 6, 2024
@Athozus Athozus added this to the 1.4.1 milestone Aug 6, 2024
@MoNTE48
Copy link
Contributor

MoNTE48 commented Aug 6, 2024

@luk3yx

@Athozus
Copy link
Member Author

Athozus commented Aug 6, 2024

Btw, normally until the repair hasn't finished, it is still noted as v3, but be sure that it is in order to run the repair. And do a backup, as I don't really want to break my Minetest by regressing version 😁 .

Copy link
Contributor

@luk3yx luk3yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another call to mail.storage:get_keys() in is_uuid_existing without a check that causes a crash.

migrate.lua Outdated Show resolved Hide resolved
migrate.lua Outdated Show resolved Hide resolved
Athozus and others added 3 commits August 7, 2024 14:55
@Athozus
Copy link
Member Author

Athozus commented Aug 7, 2024

Is it okay now @luk3yx ?

@luk3yx
Copy link
Contributor

luk3yx commented Aug 8, 2024

It works now, thanks!

@Athozus Athozus merged commit b9982f1 into master Aug 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Cleanup Cleanup of bad code or other redundant/unnecessary stuff Release blocker No release until this is closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StorageRef:get_keys() is a nil value
3 participants