Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt and download scripts #1

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

morlikowski
Copy link

Hi there!

I was able to run your code smoothly after figuring out the dependencies and getting the data from the provided URLs. To make this process a little easier for others, I've added a requirements.txt, a few shell scripts (to download the data/tools) and instructions to the readme. Please review!

All best,
Matthias

@mtanti
Copy link
Owner

mtanti commented Sep 22, 2017

Hi Matthias. Can I ask you why you put all those pip requirements in the requirements.txt file? I only needed some 3 requirements originally, I think.

@morlikowski
Copy link
Author

morlikowski commented Sep 25, 2017

Hi, sure! I basically kept installing dependencies until I was able to run the script in a new virtualenv. Then I just did pip freeze, so that's why it is very verbose. Probably tensorflow, future, scikit-image, scipy and matplotlib is enough. Would you like me to test?

Oh, and frankly I've just realized that my script does not download the results of the COCO dataset, so that evaluation fails. Let me fix that aswell.

@morlikowski morlikowski changed the title requierments.txt and download scripts requirements.txt and download scripts Sep 25, 2017
@mtanti
Copy link
Owner

mtanti commented Sep 28, 2017

Is matplotlib needed?

Also, you seem to have misunderstood what "mscoco_dir" is referring to. It's referring to the evaluation toolkit not the dataset. So this is wrong:
mscoco_dir = get_raw_input_data_dir("coco")

Can you please remove the backup text files (those that have ~ in their file name) as well?

In README you can say that the results folder has to be cleared before running the program.

Sorry I am taking so long to give feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants