Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http does not bring in OpenSSL. It must be explicitly required #81

Merged
merged 1 commit into from
Sep 25, 2016
Merged

net/http does not bring in OpenSSL. It must be explicitly required #81

merged 1 commit into from
Sep 25, 2016

Conversation

rzane
Copy link
Contributor

@rzane rzane commented Sep 24, 2016

  • [ ] Tests added
  • All tests pass
  • Branch is up to date and mergeable
  • [ ] README and documentation updated

Changes

#75 replaced RestClient with net/http, which doesn't bring in openssl. So, uses of https://github.com/circle-cli/circle-cli, have been encountering the following issue in circle-cli/circle-cli#21:

/Users/duncan/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/circleci-1.0.1/lib/circleci/request.rb:11:in `<class:Request>': uninitialized constant CircleCi::Request::OpenSSL (NameError)
Did you mean?  OpenStruct

Verify

To reproduce, run the following command within the repo:

$ bundle exec irb -r circleci

Notes

I couldn't add tests for this, because I think VCR brings in OpenSSL.

@mtchavez
Copy link
Owner

Good catch, that's embarrassing. Going to cut a quick patch release with the fix. Thanks.

@mtchavez mtchavez merged commit a065eb9 into mtchavez:master Sep 25, 2016
@rzane
Copy link
Contributor Author

rzane commented Sep 25, 2016

Sneaky tests! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants