Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Cards names in chat #4

Closed
guirto opened this issue Nov 4, 2014 · 7 comments
Closed

Suggestion: Cards names in chat #4

guirto opened this issue Nov 4, 2014 · 7 comments

Comments

@guirto
Copy link

guirto commented Nov 4, 2014

First of all, congrats on a great job. Can't wait to see it finished. If it is something I can do, I will be glad to help. I'm a web developer, and can help on javascript, jquery, html and mongodb.

I want to make a suggestion. What if card names in chat offers a card view when hovering? Just like when you hover an actual card.

Best regards.
Víctor.

@ZogStriP
Copy link
Contributor

ZogStriP commented Nov 5, 2014

👍

@mtgred
Copy link
Owner

mtgred commented Nov 13, 2014

Hi, I like the idea and will add it to the TODO list. The current development focus on the game engine so it might take a while before it's done unless someone takes it up. In the meanwhile you can try this chrome plugin that provides the functionality https://chrome.google.com/webstore/detail/netrunner-lookup/falbpbbdomlkdjlfippfjopgihdekanf?hl=en

@guirto
Copy link
Author

guirto commented Nov 13, 2014

Great!

Thank you very much.

2014-11-13 16:20 GMT+00:00 Minh Tran notifications@github.com:

Hi, I like the idea and will it to the TODO list. The current development
focus on the game engine so it might take a while before it's done unless
someone takes it up. In the meanwhile you can try this chrome plugin that
provides the functionality
https://chrome.google.com/webstore/detail/netrunner-lookup/falbpbbdomlkdjlfippfjopgihdekanf?hl=en


Reply to this email directly or view it on GitHub
#4 (comment).

@queueseven
Copy link
Collaborator

I'm trying to implement this, but I have no knowledge about om/react etc. If someone want's to help me, I described my problem here: #328

@queueseven
Copy link
Collaborator

I'm making progress.

You can take a look here: https://i.imgur.com/HWxlWG7.gif
or see my branch here: https://github.com/DominicKexel/netrunner/tree/cards

Currently I pass a string like [Paige Piper|08004] to the client, so the client knows what URL to display.

I would like the players to be able to also simply type the card name, and the preview should automatically work, as this would also allow me to let the server side mostly unchanged.

(Right know a user could type [Something|A random card id] to mess with the preview)

I was thinking of fetching all cards (just :title and :code) once from the database (maybe store it locally?) and then look up if I find a card title in the message once it gets displayed, and attach the event handler with the correct card code.

Thoughts?

@mtgred
Copy link
Owner

mtgred commented Jul 22, 2015

All the cards data are already fetched on init and kept in memory on the client side. You can access the cards array with (:cards @app-state).

Based on the card name you can look up the card code to display the card image. Have a look at cardbrowser.cljs as an example.

@queueseven
Copy link
Collaborator

Thanks, good to know.

mtgred pushed a commit that referenced this issue Apr 6, 2017
Changing Mars for Martians per request
nealterrell pushed a commit that referenced this issue Jun 13, 2018
Tidies up ability costs and removes unused code.
nealterrell pushed a commit that referenced this issue Jul 18, 2018
NoahTheDuke pushed a commit that referenced this issue Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants