Implement Subroutine Tracking #4265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahTheDuke
force-pushed
the
nb/implement-subroutine-tracking
branch
from
57102f6
to
9e20900
Compare
lostgeek
reviewed
Jun 8, 2019
NoahTheDuke
force-pushed
the
nb/implement-subroutine-tracking
branch
2 times, most recently
from
f784aac
to
51ae122
Compare
lostgeek
reviewed
Jun 14, 2019
NoahTheDuke
force-pushed
the
nb/implement-subroutine-tracking
branch
from
51ae122
to
4b7357c
Compare
NoahTheDuke
force-pushed
the
nb/implement-subroutine-tracking
branch
2 times, most recently
from
1949da4
to
1c30571
Compare
lostgeek
reviewed
Jul 15, 2019
NoahTheDuke
force-pushed
the
nb/implement-subroutine-tracking
branch
5 times, most recently
from
56cf95d
to
76e7558
Compare
NoahTheDuke
force-pushed
the
nb/implement-subroutine-tracking
branch
from
995d000
to
71263a5
Compare
…yoga, Ravana, Marcus Batty
NoahTheDuke
force-pushed
the
nb/implement-subroutine-tracking
branch
from
889f3c9
to
2601f7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hot on the heels of @lostgeek's success with #4262, and nearly one full year after @presheaf wrote up #3638, I feel emboldened to implement another facet of the game we've so far left players to handle themselves!
SUBROUTINE TRACKING
Goals:
Triggering eventsImplement all cards that listen with subroutine-related eventsTriggering events and implementing non-breaking cards that interact with subroutines will come in another PR. This is purely for numbering and "breaking" them in as dumb and obvious a way as possible. It's already massive, so I want to limit the amount of change happening.
Closes #3638