Namespace eid-related functions #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahTheDuke
force-pushed
the
nb/namespace-eid
branch
2 times, most recently
from
6e1cfe3
to
30f0d2a
Compare
NoahTheDuke
force-pushed
the
nb/namespace-eid
branch
from
30f0d2a
to
7b42b16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing a monolith PR like #4251, I've decided to go one file or group of functions at a time, cleaning and moving as I go. I hope to have these PRs be relatively short-lived, and iterate quickly. This is PR 1 of XX.
In this PR, I've moved the
eidcreation and manipulation-related functions into a single namespace, and then imported only the needed functions into each other namespace. I view this as the highest point on the call graph. Everything should need these, these functions should need no others.