Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes around pay-credits prompts #4290

Merged
merged 6 commits into from
Jul 12, 2019
Merged

Conversation

lostgeek
Copy link
Contributor

@lostgeek lostgeek commented Jun 26, 2019

This PR will contain the bugfixes for the new pay-credits prompts.

Changes

  • Feature: Credit costs are printed explicitly in most cases now, even if zero.
    • Exception: Installing cards in a remote / root of a central.
  • Fix: Auto-pumping breakers now merges total costs. Closes Auto-pumping Icebreaker with pay-credits prompt leads to wrong strength #4295.
  • Fix: All runner cards now add :source-type to the runner-install eid.
    • This has to be done for every action that is done by card abilities and induces a pay-credits prompt

@NoahTheDuke
Copy link
Collaborator

This looks sweet! I love the changes you made. One note about the tests: we have a last-log-contains? that does p much what your comparisons do. Might help make your tests more readable!

@NoahTheDuke
Copy link
Collaborator

I don't wanna make you undo all of the work you just did, but could we just default to the correct :source-type in runner-install? That way we can leave it unspecified and it'll choose correctly, and override where we need to.

@lostgeek
Copy link
Contributor Author

lostgeek commented Jul 8, 2019

Oh you're right. That was a case of having too much fun fiddling with vim macros and too little thinking 😂

That being said, we should probably still keep the changes because we're specifying :source card in there.

@NoahTheDuke
Copy link
Collaborator

Maybe just remove the :source-type part then? Seems like a lot of repetition in the code.

@lostgeek
Copy link
Contributor Author

lostgeek commented Jul 8, 2019

Yeah I'll certainly do that and look at all the other cases again (corp-install and so on). This should be the default behavior of all the pay-credits relevant actions.

@NoahTheDuke NoahTheDuke merged commit 5ba3dd5 into mtgred:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-pumping Icebreaker with pay-credits prompt leads to wrong strength
2 participants