Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better damage prevention messages #4309

Merged
merged 6 commits into from
Jul 12, 2019

Conversation

lostgeek
Copy link
Contributor

@lostgeek lostgeek commented Jul 5, 2019

Changelog

@lostgeek
Copy link
Contributor Author

lostgeek commented Jul 5, 2019

Here's the new prevention in action (Heartbeat preventing one net damage):

Prevention

Note: This behavior has been further changed. The prompt in the third image wouldn't even be displayed anymore.

@lostgeek
Copy link
Contributor Author

lostgeek commented Jul 5, 2019

A lot of broken tests, because the last commit removed the [Done] button on a lot of damage prevention prompts.

@NoahTheDuke
Copy link
Collaborator

Why change the damage prevention function to private? Seems like it doesn’t make things any clearer

@lostgeek
Copy link
Contributor Author

lostgeek commented Jul 6, 2019

I thought it might make it a bit cleaner, if I don't dump all that code into the damage-prevent function.

@NoahTheDuke
Copy link
Collaborator

Oh I see, I only looked at the commit diff, forgot to check the full diff. Yeah, you made the right call.

@NoahTheDuke NoahTheDuke merged commit e65bcef into mtgred:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants