Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major refactor of costs, fix cost strings to only print "Pay" when necessary #4330

Merged
merged 20 commits into from
Jul 29, 2019
Merged

Major refactor of costs, fix cost strings to only print "Pay" when necessary #4330

merged 20 commits into from
Jul 29, 2019

Conversation

NoahTheDuke
Copy link
Collaborator

Closes #4316

@NoahTheDuke NoahTheDuke changed the title Fix cost strings to only print "Pay" when necessary Major refactor of costs, fix cost strings to only print "Pay" when necessary Jul 27, 2019
lostgeek
lostgeek reviewed Jul 27, 2019
View reviewed changes
Copy link
Contributor

@lostgeek lostgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only skimmed over the code but this looks really clean and solid 👍

src/clj/game/core/costs.clj Outdated Show resolved Hide resolved
@NoahTheDuke NoahTheDuke merged commit b813046 into mtgred:master Jul 29, 2019
@NoahTheDuke NoahTheDuke deleted the nb/fix-pay-cost-labels branch July 29, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostgeek lostgeek lostgeek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build-cost-str strings are broken
2 participants
@NoahTheDuke @lostgeek