Allow triggering nil events #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to allow for conditionally triggering an event without having to split fork at every single later junction. Will make weaving `wait-for` through engine code much simpler and more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event of a
nilevent,effect-completedwill be called and the calledtrigger-eventvariation will be exited immediately.This is to allow for conditionally triggering an event without having to split fork at every single later junction. Will make weaving
wait-forthrough engine code much simpler and more readable.To demonstrate how this will look, I refactored the existing
:spent-stealth-creditscalls to be awaitable (as they technically should be, cuz Net Mercur's handler is async (prompts yo)).