Fix computed properties #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles computed properties like:
const {[`${foo}bar`]: x} = someOb;
Not only was this throwing errors, but we weren't really deciding
how to sort them either. For now, we are just putting them all at the
bottom.
mthadley
force-pushed
the
fix-computed-properties
branch
from
21469c7
to
a0a6f49
Compare
|
Tested in our codebase and works great! Thanks for the quick turnaround on the fix, and thanks for this great lint rule overall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to handle computed properties like those mentioned in #15 with a bit more grace.
Fixes #15.