Fix parsing of empty line continuations for commands (#65)

mthalman · Nov 26, 2020 · 35be2c4 · 35be2c4
1 parent 67393f0
commit 35be2c4
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 3 deletions.
diff --git a/src/DockerfileModel/DockerfileModel.Tests/RunInstructionTests.cs b/src/DockerfileModel/DockerfileModel.Tests/RunInstructionTests.cs
@@ -137,6 +137,20 @@ public static IEnumerable<object[]> ParseTestInput()
                     }
                 },
                 new RunInstructionParseTestScenario
+                {
+                    Text = "RUN `\n`\necho hello",
+                    EscapeChar = '`',
+                    TokenValidators = new Action<Token>[]
+                    {
+                        token => ValidateKeyword(token, "RUN"),
+                        token => ValidateWhitespace(token, " "),
+                        token => ValidateLineContinuation(token, '`', "\n"),
+                        token => ValidateLineContinuation(token, '`', "\n"),
+                        token => ValidateAggregate<ShellFormCommand>(token, "echo hello",
+                            token => ValidateLiteral(token, "echo hello"))
+                    }
+                },
+                new RunInstructionParseTestScenario
                 {
                     Text = "RUN echo `\n#test comment\nhello",
                     EscapeChar = '`',

diff --git a/src/DockerfileModel/DockerfileModel.Tests/ShellFormCommandTests.cs b/src/DockerfileModel/DockerfileModel.Tests/ShellFormCommandTests.cs
@@ -109,6 +109,20 @@ public static IEnumerable<object[]> ParseTestInput()
                     }
                 },
                 new ShellFormCommandParseTestScenario
+                {
+                    Text = "echo`\n  `\n  hello",
+                    EscapeChar = '`',
+                    TokenValidators = new Action<Token>[]
+                    {
+                        token => ValidateAggregate<LiteralToken>(token, "echo`\n  `\n  hello",
+                            token => ValidateString(token, "echo"),
+                            token => ValidateLineContinuation(token, '`', "\n"),
+                            token => ValidateString(token, "  "),
+                            token => ValidateLineContinuation(token, '`', "\n"),
+                            token => ValidateString(token, "  hello")),
+                    }
+                },
+                new ShellFormCommandParseTestScenario
                 {
                     Text = "ec`\nho `test",
                     EscapeChar = '`',

diff --git a/src/DockerfileModel/DockerfileModel/ParseHelper.cs b/src/DockerfileModel/DockerfileModel/ParseHelper.cs
@@ -308,9 +308,11 @@ public static Parser<IEnumerable<Token>> LiteralString(char escapeChar, IEnumera
         /// </summary>
         /// <param name="escapeChar">Escape character.</param>
         public static Parser<IEnumerable<Token>> ArgumentListAsLiteral(char escapeChar) =>
-            from literals in ArgTokens(
-                LiteralToken(escapeChar, Enumerable.Empty<char>()).AsEnumerable(),
-                escapeChar).Many()
+            from literals in
+                ArgTokens(
+                    from literal in LiteralToken(escapeChar, Enumerable.Empty<char>()).Optional()
+                    select new Token[] { literal.GetOrDefault() },
+                    escapeChar).Many()
             select CollapseLiteralTokens(literals.Flatten(), canContainVariables: false, escapeChar);
 
         /// <summary>