Redesign identifier token #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesigns the class structure of
IdentifierToken. This changes the class to be abstract and it now has two derived class:StageNameandVariable. This was done in order for identifiers to have parsing of the input to handle things like line continuations. Each identifier type has its own syntax (i.e. allowed characters) so this is encapsulated in the derived classes.This also redesigns the
ImageNameclass. Its constituent components were originally publicly exposed and derived fromIdentifierToken. This was incorrect. They now derive fromLiteralTokenand have been made private. TheImageNameclass no longer exposes its constituent tokens other than via the general purposeTokensproperty.