Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single quotes are removed #111

Closed
Sylry opened this issue Nov 9, 2021 · 2 comments
Closed

Single quotes are removed #111

Sylry opened this issue Nov 9, 2021 · 2 comments

Comments

@Sylry
Copy link
Contributor

Sylry commented Nov 9, 2021

The single quote ' is removed but, imho, should not

I'll provide a PR to fix it, with a test
mtibben added a commit that referenced this issue Nov 10, 2021
@mtibben
Merge pull request #112 from Sylry/preserve_single_quotes
b0fb318 
Preserves single quotes. Fixes #111
@Sylry
Copy link
Contributor Author

Sylry commented Nov 10, 2021

Thanks for the quick merge!

What do you think about a new release including it? :-)

@davidearl
Copy link

I have just hit this. Would it be possible for you to create a new composer release which includes this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidearl @Sylry