Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up PHP 8.2 compatibility, duplicated test run #119

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

iansltx
Copy link
Contributor

@iansltx iansltx commented Jun 27, 2023

See #113 and #117, though for the latter this fixes reversions that affect #117. Combined with tweaks to the tests, this gets us a clean run (no deprecation errors) on PHP 8.2.

Copied from mtibben#113.

Passing null as the second parameter is deprecated in PHP 8.1. When using the
legacyConstruct function the htmlFuncFlags are never set and passing null
into html_entity_decode.

This move setting htmlFuncFlags above the legacy check to ensure they are
always set to prevent passing null into html_entity_decode.
Other instances of trim() operate on known strings, so they don't need to be null-coalesced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants