Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html-nano): set svg minification to false #17

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

wallace41290
Copy link
Collaborator

@wallace41290 wallace41290 commented Jun 1, 2020

Apparently the html-nano plugin for the parcel bundler has a svg minification process that stripped out the viewBox attribute and whatever was messing up the calendar icon. Set to false for the fix.

parcel-bundler/parcel#1523

RJE-15 RJE-14

@wallace41290 wallace41290 self-assigned this Jun 1, 2020
Copy link
Contributor

@nmrichards nmrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough

@wallace41290 wallace41290 merged commit 5045a63 into master Jun 1, 2020
@wallace41290 wallace41290 deleted the RJE-15-lost-spacing branch June 1, 2020 14:32
@wallace41290
Copy link
Collaborator Author

🎉 This PR is included in version 1.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants