Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Python 3.12 #353

Merged
merged 2 commits into from
Nov 4, 2023
Merged

Test on Python 3.12 #353

merged 2 commits into from
Nov 4, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 3, 2023

@mtreinish
Copy link
Owner

I think the failures in tests here are because testtools isn't compatible with Python 3.12. This PR: testing-cabal/testtools#353 fixes it on main, but it hasn't been released yet.

@jcapiitao
Copy link

The patch can be rebased as testtools is now availalble for Python3.12 since 2.7.0 [1]

[1] https://pypi.org/project/testtools/2.7.0/

@mtreinish mtreinish merged commit 11584e7 into mtreinish:main Nov 4, 2023
21 checks passed
@cclauss cclauss deleted the patch-1 branch November 4, 2023 13:31
@jcapiitao
Copy link

Thank you guys, do you plan to issue a new release supporting py3.12 soon ? No pressure, just wondering

@mtreinish
Copy link
Owner

We can push out a quick bugfix release if needed, but there weren't any code changes associated with this PR. So the bugfix would just be package metadata. This PR was just adding the 3.12 testing to CI, I believe the 4.1.0 release should be 3.12 compatible. We were blocked on testing in CI before because our upstream dependencies weren't 3.12 compatible in a release yet. But now that's been solved installing 4.1.0 should work. If it doesn't definitely open an issue and we can quickly push out 4.1.1

@jcapiitao
Copy link

Great, thank you @mtreinish 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants