Support for query string parameters #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" vs. "?key=value")
|
Totally needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on a single page app (coming from a world of server-client app work), and wanted to use query string params as a way to quickly trigger a debug flag to expose some debugging information, or to override mocked AJAX requests.
I created this PR because I saw an issue related to this, and thought you might be swayed by updated tests + this gist that outlines the effect of the feature: https://gist.github.com/pkarl/4758430
Let me know what you think, and if I missed anything in the list of prereqs for a PR. Thanks for pathjs!
/edit Also, it was path.js 0.8.4