Reset params object with each attempted route match. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Otherwise params accumulate with each attempted match.
…es in the potentially matched route of the same string as the value of a variable were being replaced since a regex based string replace method was being used. Refactored to actually replace the correct index of the compared route followed by rejoining it into its string form for comparison. This ensures no collisions between variable values and similar substrings in the route.
|
I need to recreate this pull request from a dedicated branch to separate the two commits. (Rookie) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I first came across this by iterating through my definitions list using a while(i--). The params object ends up accumulating params from every possible route match that didn't match the final route. This leads to unexpected results. I've updated them the for loop to simply reset the params object at the beginning of each pass to ensure it's clean for the next pass.