Properly surface socket level errors on Plug.Conn.chunk/2 calls

mtrudel · Nov 29, 2024 · 9dbc816 · 9dbc816
1 parent cc206b0
commit 9dbc816
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/bandit/adapter.ex b/lib/bandit/adapter.ex
@@ -186,6 +186,7 @@ defmodule Bandit.Adapter do
         {:ok, nil, send_data(adapter, encoded_chunk, false)}
       end
     rescue
+      error in Bandit.SocketError -> {:error, error.socket_error}
       error -> {:error, Exception.message(error)}
     end
   end

diff --git a/test/bandit/http1/request_test.exs b/test/bandit/http1/request_test.exs
@@ -2448,7 +2448,7 @@ defmodule HTTP1RequestTest do
       conn = send_chunked(conn, 200)
 
       Process.sleep(200)
-      assert chunk(conn, "IMPOSSIBLE") == {:error, "closed"}
+      assert chunk(conn, "IMPOSSIBLE") == {:error, :closed}
 
       conn
     end
-Original file line number
+Diff line change
@@ Expand Up / @@ -186,6 +186,7 @@ defmodule Bandit.Adapter do @@
             {:ok, nil, send_data(adapter, encoded_chunk, false)}
           end
         rescue
+          error in Bandit.SocketError -> {:error, error.socket_error}
           error -> {:error, Exception.message(error)}
         end
       end
@@ Expand Down @@