Tweaks to how Bandit handles unexpected messages #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrudel
commented
Nov 2, 2023
| @@ -197,4 +197,31 @@ defmodule Bandit.HTTP1.Handler do | |||
|
|
|||
| def handle_info({:EXIT, _pid, :normal}, {socket, state}), | |||
| do: {:noreply, {socket, state}, socket.read_timeout} | |||
|
|
|||
| def handle_info(msg, state) do | |||
| # Copied verbatim from lib/elixir/lib/gen_server.ex | |||
There was a problem hiding this comment.
Ideally we'd just call super(msg, state) here but calling super on (most) GenServer callbacks was deprecated a while ago
josevalim
reviewed
Nov 2, 2023
| case Process.info(self(), :registered_name) do | ||
| {_, []} -> self() | ||
| {_, name} -> name | ||
| end |
There was a problem hiding this comment.
Do you allow the process to be registered? If not you can skip this, otherwise it looks good to me :)
There was a problem hiding this comment.
Yep, handler processes themselves are able to accept any valid gen_server option via the genserver_options flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, unexpected messages received by an HTTP/1 handler would crash the server; this PR updates this behaviour to log messages in the same way that a stock GenServer which does not implement any
handle_info/2callbacks does, and thence does not crash.Note there's no need to add a similar mechanism on HTTP/2 handlers, since HTTP/2 requests are backed (at least for now) by
TaskAlso note that there's no need to add a similar mechanism to WebSockets, since WebSock already provides a way to forward handle_info calls to the websock implementor. In fact, this PR also stops explicitly catching normal monitored process termination calls in the websocket handler for this reason.