test: make less likely that test run into :eaddrinuse failure locally #419
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrudel
reviewed
Nov 13, 2024
test/bandit/server_test.exs
Outdated
| @@ -25,7 +25,7 @@ defmodule ServerTest do | |||
| end | |||
|
|
|||
| test "server logs connection error detail log at startup" do | |||
| pid = start_supervised!({Bandit, scheme: :http, plug: __MODULE__}) | |||
| pid = start_supervised!({Bandit, scheme: :http, plug: __MODULE__, port: 40_000}) | |||
There was a problem hiding this comment.
You can pass a value of 0 for port and it will pick an open port automatically.
There was a problem hiding this comment.
Oh, cool, like gen_tcp 👏
There was a problem hiding this comment.
Yup, exactly. Bandit is just a thin layer on Thousand Island which is just a thin layer on gen_tcp. It's all transparent
mtrudel
reviewed
Nov 13, 2024
test/bandit/server_test.exs
Outdated
Comment on lines
59
to
60
| start_supervised({Bandit, plug: __MODULE__, port: 4000}) | ||
| start_supervised({Bandit, plug: __MODULE__, port: 4001}) | ||
| start_supervised({Bandit, plug: __MODULE__, port: 40_000}) | ||
| start_supervised({Bandit, plug: __MODULE__, port: 40_001}) |
mtrudel
reviewed
Nov 13, 2024
Comment on lines
+28
to
+30
| {:ok, {address, port}} = | ||
| start_supervised!({Bandit, scheme: :http, plug: __MODULE__, port: 0}) | ||
| |> ThousandIsland.listener_info() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minor dev ergnomics thing.
When working on previous PRs, I sometimes got eaddrinuse locally while occasionally running bandit test because of having other phoenix apps on default 4000 on the side 🙂