Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests #446

Merged
merged 16 commits into from
Jan 4, 2025
Merged

Improve tests #446

merged 16 commits into from
Jan 4, 2025

Conversation

mtrudel
Copy link
Owner

@mtrudel mtrudel commented Jan 2, 2025

  • Run tests async
  • Get rid of sleep calls in tests that were there only to (racily!) capture logs / telemetry, and replace with receive based log / telemetry test helpers
  • Test suite speedup of about 10x!
  • Add plug to telemetry metadata
  • Add plug to logging metadata
  • Improve many sad path logging cases to include a full suite of metadata

@mtrudel
Copy link
Owner Author

mtrudel commented Jan 4, 2025

In the interest of review ability I'm going to merge this even though there's still some test improvements to be done. Things 'coming soon' after this goes out:

  • Use the same message based approach to log testing for WebSockets. Requires a rethink of how we do logging in the WebSocket stack
  • Split http1/request_test.exs into http1/{plug, protocol}_test.exs to mirror the pattern for http2 and websocket

@mtrudel mtrudel merged commit 32478bb into main Jan 4, 2025
27 checks passed
@mtrudel mtrudel deleted the improve_tests branch January 4, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant