Add option to return next #N rows when showing table records

[dnlw07]

Is your feature request related to a problem? Please describe.
Add option to return first 50 rows only, and add button in query result "return next 50 records" and "return all results"

[mtxr]

Hi.

We currently have the option to return just the #N records. See:

vscode-sqltools/.test-database/project.code-workspace

Line 29 in bb29d5b

"limit": 100,

I like the idea of paginating it. But meanwhile you can show the first #N records and if needs more, the query needs to be manually.

[dnlw07]

Thanks for feedback,
I have checked that setting, but I am afraid "limit": 100, is not working.

After applying that setting, querying a big table still returns its all results, instead first 100 only.

I need to manually add condition where rownum >100 to my SQL script to return first 100 only.

[mickeypearce]

The limit applies only to "Show table records" command and not when executing a general query ("Run this file | query"), is that correct @mtxr?

With "Show table records" it works in my case. You can see the actual query executed if you click on "QUERY DETALS" at the bottom of the results grid (query ends with "....rownum <= 10", when you set "sqltools.results": { "limit": 10 }, to give an example).

[mtxr]

That's correct. We just limit queries we generate. What user type we avoid changing

…

On Tue, Oct 1, 2019, 05:38 Mickey Pearce ***@***.***> wrote: The limit applies only to "Show table records" command and not when executing a general query ("Run this file | query"), is that correct @mtxr <https://github.com/mtxr>? With "Show table records" it works in my case. You can see the actual query executed if you click on "QUERY DETALS" at the bottom of the results grid. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#365?email_source=notifications&email_token=AAFMX2PJBR5WZR2CKQFZPJTQMMEBNA5CNFSM4ITAQNMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAAO75I#issuecomment-536932341>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFMX2LNKLSNLKX362ETNYLQMMEBNANCNFSM4ITAQNMA> .

[dnlw07]

Yes, you are right.
However I believe it would be a nice option to add this functionality even for what user is typing (it does not to be a default behavior).
Many tools already have it, like SQL Developer or SQuirreL, etc.
I found myself it's a bit annoying to each time add/remove the additional filter condition rownum <= 100, to not "kill" DB.

[mtxr]

Since we don't want to change the query without his approval, let's add an alert first.

Requirements:

1. Show an alert You are running a select query that has no limit clause, would you like to add it before continue? before changing the query.

[dnlw07]

Yeah, good idea!
By default the alert should be always shown.
However, please consider the option to turn off the alert in settings.

[mtxr]

You are totally right. Evolving requirements:

Requirements:

1. Show an alert You are running a select query that has no limit clause, would you like to add it before continue? before changing the query.
2. Add an option to ignore this alerts

[mtxr]

Done on v0.22. Closing

[johndevedu]

@mtxr which version of v0.22 has this? Could not find it in the changelog. I'm currently on v0.22.9 and wondering what the syntax is for enabling this feature. Thanks!

[mtxr]

Hi @johndevedu , it's the first version, it's enabled by default also so you should be seeing this on any queries resulting in rows number bigger than the limit

[johndevedu]

@mtxr I am not getting the alert when doing a select query on 0.22.9. I have the limit set to:

  "sqltools.results": {
    "limit": 20
  }

[mathief123]

Hi! I'm also not getting the alert, is it fixed yet?

[vibhavagarwal5]

Is this working? I dont see any alerts. @mtxr @gjsjohnmurray how to auto set limits while running query? can the extension auto set limit to queries?

[gjsjohnmurray]

My searches of the codebase didn't find this implemented anywhere. @mtxr did I miss something?