Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple MSSQL driver improvements #1396

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Multiple MSSQL driver improvements #1396

merged 6 commits into from
Nov 15, 2024

Conversation

fzhem
Copy link
Contributor

@fzhem fzhem commented Nov 11, 2024

Describe here what is this PR about and what we are achieving merging this.

  • Use Microsoft recommended system table to get a list of databases
  • Better error handling: Throw database configuration errors rather than retrying
  • Set default connection timeout to 15 - same as the tedious driver
  • Add tedious specific option - trustServerCertificate

Thank you for your contribution!
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You have made the needed changes to the docs
  • You have written a description of what is the purpose of this pull request above

@gjsjohnmurray
Copy link
Collaborator

@fzhem thanks for this PR. Fixes for a CI issue were merged into mtxr:dev earlier today. Please update fzhem:dev with them, then I will allow CI to run on this PR.

@fzhem
Copy link
Contributor Author

fzhem commented Nov 14, 2024

@fzhem thanks for this PR. Fixes for a CI issue were merged into mtxr:dev earlier today. Please update fzhem:dev with them, then I will allow CI to run on this PR.

Cheers dude! I've just synced the fork.

Copy link
Collaborator

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will merge this, but I don't yet know when we will be doing the next release.

@gjsjohnmurray gjsjohnmurray merged commit 2429c6f into mtxr:dev Nov 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants