Skip to content

upgrade to node 16.16.0 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

upgrade to node 16.16.0 #42

wants to merge 3 commits into from

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Aug 8, 2022

Upgrades the node version to current LTS (16.16.0).

@elpoelma elpoelma self-assigned this Aug 8, 2022
@madnificent
Copy link
Member

Discussed with @elpoelma and the upgrade of body-parser is a requirement to complete this upgrade.

@MikiDi
Copy link
Contributor

MikiDi commented Feb 15, 2023

Superseded by #51

@MPParsley
Copy link
Contributor

@elpoelma, could you rebase this or merge master?
cf. #52

* add expose statement (#39)

I was kind of surprised we didn't have this in here already. 
the [docker reference](https://docs.docker.com/engine/reference/builder/#expose) specifies this is mostly for documentation towards users of a microservice. I think it's valuable to make it clear that microservices based on the template listen on port 80. Exposed ports are  also used by other "proxy type" microservices such as the letsencrypt companion to figure out how to forward calls to the container in question.

From the reference:
> The EXPOSE instruction informs Docker that the container listens on the specified network ports at runtime. You can specify whether the port listens on TCP or UDP, and the default is TCP if the protocol is not specified.

> The EXPOSE instruction does not actually publish the port. It functions as a type of documentation between the person who builds the image and the person who runs the container, about which ports are intended to be published. To actually publish the port when running the container, use the -p flag on docker run to publish and map one or more ports, or the -P flag to publish all exposed ports and map them to high-order ports.

* Allow overriding port and hostname (#47)

* Allow overriding port and hostname

* Update server.js

* Update Dockerfile

* instructions on handling delta's in a JS service (#48)

* Add documentation to allow overriding port and hostname (#49)

* Allow overriding port and hostname

* Update server.js

* Update Dockerfile

* Update Dockerfile

* Update README.md

---------

Co-authored-by: Niels V <nvdk@users.noreply.github.com>
@nvdk
Copy link
Member

nvdk commented Aug 25, 2023

I believe this can be closed in favour of #51 ?

@erikap
Copy link
Member

erikap commented Sep 22, 2023

Closed in favour of #51

@erikap erikap closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants