ES module support on Node 16 #46
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the app is being compiled as a module, so should also the mu package. Also included the package.json files in the package's final product because Node uses that to run the project(?). I haven't tested the changes to the TypeScript configuration.
|
The Node-upgrade part of this is superseded by #51 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the installation of ES modules in a project and base on Node 16.
Since Node 14 is reaching end of life, many packages are dropping support for for it. Many packages also prefer/require the use of ES modules.
I'm not an expert, so this PR is based on the changes from the two branches that introduce ES module support and the Node 16 support. After testing it looks like the build process does not put the
package.jsonfile in themupackage. This is a requirement for any Node package, especially when Node looks for settings like"type": "module"in the package. This PR tries to fix that by just copying that file while also copying the Babel config for transpilation, but thetranspile-sources.shis convoluted, so this needs to be tested/rewritten more thoroughly.