Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeslice and onTimeStamp options in MRecordRTC #283

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

thijstriemstra
Copy link
Contributor

No description provided.

@thijstriemstra
Copy link
Contributor Author

the travis builder seems broken: https://travis-ci.org/muaz-khan/RecordRTC/builds/243289806#L305

@muaz-khan muaz-khan merged commit ffb4412 into muaz-khan:master Jun 15, 2017
@muaz-khan
Copy link
Owner

https://travis-ci.org/muaz-khan/RecordRTC has (i.e. defines+requires) following two environment variables (to use browserstack services).

Travis build works if manually (myself) merge pull-requests or add commits. Because now travis can use my environment variables.

@thijstriemstra
Copy link
Contributor Author

thijstriemstra commented Jun 15, 2017

Thanks @muaz-khan. Can you also release a new version, last one is from march.. Cheers.

Also how would I access the getArrayOfBlobs method from MRecordRTC? I would like to get the current blob data with timeSlice but I don't see a way to access it..

@muaz-khan
Copy link
Owner

muaz-khan commented Jun 15, 2017

// below 3 are RecordRTC instances:
// 1) mRecordRTC.audioRecorder
// 2) mRecordRTC.videoRecorder
// 2) mRecordRTC.gifRecorder

// RecordRTC exports "getInternalRecorder" method
var internal = mRecordRTC.videoRecorder.getInternalRecorder();

// only for MediaStreamRecorder
// i.e.     (internal instanceof MediaStreamRecorder) === true
var blobs = internal.getArrayOfBlobs();
var blob = new Blob(blobs, {
    type: 'video/webm'
});

@thijstriemstra
Copy link
Contributor Author

Thanks, turns out I was using an old CDN version (downloaded yesterday) but it's latest version works now.

@thijstriemstra
Copy link
Contributor Author

@muaz-khan it seems setting timeSlice to a different value doesn't have any impact? is this a bug?

AndersDJohnson pushed a commit to AndersDJohnson/RecordRTC that referenced this pull request Apr 8, 2019
add timeslice and onTimeStamp options in MRecordRTC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants