Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/element] URL bar completely white #317

Open
3 tasks done
inxomnyaa opened this issue Apr 6, 2022 · 24 comments · Fixed by manueljimenezs/MaterialFox-kino#1 · May be fixed by #322
Open
3 tasks done

[Feature/element] URL bar completely white #317

inxomnyaa opened this issue Apr 6, 2022 · 24 comments · Fixed by manueljimenezs/MaterialFox-kino#1 · May be fixed by #322
Labels
bug Something isn't working

Comments

@inxomnyaa
Copy link

Sanity checks (must complete)

  • I have read and followed the installation instructions in the README
  • I have not modified the userChrome.css file
  • I have tested the latest release for my Firefox version, or commit on master/beta branch (beta is for Firefox Beta only)

Describe the bug
The url bar and box appear fully white, making text unreadable

To Reproduce
Steps to reproduce the behavior:

  1. Use any theme in the latest version, even defaut ones

Screenshots
image

System info

  • OS: [e.g. Windows 10]
  • Firefox version: 100.0b2
@inxomnyaa inxomnyaa added the bug Something isn't working label Apr 6, 2022
@missuo
Copy link

missuo commented Apr 7, 2022

I had the same problem on macOS 12.3.1 with Firefox 100.0b2.

@Lord-Lavios
Copy link

I changed the --toolbar-field-background-color, --toolbar-hover-background-color, and --toolbar-field-focus-background-color value in the variables.css file to something other than a hsl(), and it works. rgb(43, 42, 51) is a close enough color for the Firefox dark theme.

@missuo
Copy link

missuo commented Apr 7, 2022

I changed the --toolbar-field-background-color, --toolbar-hover-background-color, and --toolbar-field-focus-background-color value in the variables.css file to something other than a hsl(), and it works. rgb(43, 42, 51) is a close enough color for the Firefox dark theme.

Thanks a lot. I also succeeded.

@mtzfox
Copy link

mtzfox commented Apr 11, 2022

@Lord-Lavios thanks, that worked for me.

@juanpabloalfonzo
Copy link

I changed the --toolbar-field-background-color, --toolbar-hover-background-color, and --toolbar-field-focus-background-color value in the variables.css file to something other than a hsl(), and it works. rgb(43, 42, 51) is a close enough color for the Firefox dark theme.

Worked for me as well, thanks! Just a note that for me it was --toolbar-field-hover-background-color instead of --toolbar-hover-background-color in case anyone runs into this in their variables.css file. The other two variables had the same name as yours though.

@melodicwang
Copy link

This theme is the best stlye for firefox, and it is one of the reason that i sitll use firefox not chrome.

@ghost
Copy link

ghost commented May 7, 2022

I changed the --toolbar-field-background-color, --toolbar-hover-background-color, and --toolbar-field-focus-background-color value in the variables.css file to something other than a hsl(), and it works. rgb(43, 42, 51) is a close enough color for the Firefox dark theme.

I use a Mac, so now it works great in dark mode, but when it switches to light mode the bar stays dark, is there any way to make a real fix so that way it switches between the two like it used to

@Grogs
Copy link

Grogs commented May 7, 2022

when it switches to light mode the bar stays dark, is there any way to make a real fix so that way it switches between the two like it used to

I added the following around line 170 in variables.css (under :root:not(:-moz-lwtheme):not([privatebrowsingmode=temporary])):

	--toolbar-field-background-color: rgb(241, 243, 245) !important;
	--toolbar-field-hover-background-color: rgb(232, 235, 236) !important;
	--toolbar-field-focus-background-color: rgb(255, 255, 255) !important;

@ghost
Copy link

ghost commented May 9, 2022

when it switches to light mode the bar stays dark, is there any way to make a real fix so that way it switches between the two like it used to

I added the following around line 170 in variables.css (under :root:not(:-moz-lwtheme):not([privatebrowsingmode=temporary])):

	--toolbar-field-background-color: rgb(241, 243, 245) !important;
	--toolbar-field-hover-background-color: rgb(232, 235, 236) !important;
	--toolbar-field-focus-background-color: rgb(255, 255, 255) !important;

Capture d’écran 2022-05-08 à 23 31 46

It almost worked, matches the colour but now weird translucent results

@DoNotResuscitate
Copy link

Any plans to fix this in the latest version of this?

infokiller added a commit to infokiller/MaterialFox that referenced this issue May 14, 2022
@quarkquartet
Copy link

Same issue here
image

@privacyguy123
Copy link

id argue the color it's meant to be is rgb(28, 27, 34)

@ghost
Copy link

ghost commented May 18, 2022

id argue the color it's meant to be is rgb(28, 27, 34)

Still doesn't change the fact that it only works in dark mode

@Trident6355
Copy link

Does anyone actually bother with this?
Guess I have to switch to Chrome since this issue essentially makes this theme unusable

@DoNotResuscitate
Copy link

@muckSponge do you have any insight into what changed with the latest Firefox version to break this?

@fmeyertoens
Copy link
Contributor

The CSS selector used to detect a dark theme (:-moz-lwtheme-brighttext) seems not to work anymore:

:root:-moz-any(:-moz-lwtheme-brighttext, [privatebrowsingmode=temporary])
{
--toolbar-field-background-color: #202124 !important;
--toolbar-field-hover-background-color: #292a2d !important;
--toolbar-field-focus-background-color: #202124 !important;
}

Replacing it with [lwtheme-brighttext] should restore the old behavior.

@Trident6355
Copy link

You Sir are a legend. Thank you very much! Fixed it for me.

@quarkquartet
Copy link

You are GOAT. Works for me.

@ghost
Copy link

ghost commented May 20, 2022

The CSS selector used to detect a dark theme (:-moz-lwtheme-brighttext) seems not to work anymore:

:root:-moz-any(:-moz-lwtheme-brighttext, [privatebrowsingmode=temporary])
{
--toolbar-field-background-color: #202124 !important;
--toolbar-field-hover-background-color: #292a2d !important;
--toolbar-field-focus-background-color: #202124 !important;
}

Replacing it with [lwtheme-brighttext] should restore the old behavior.

Capture d’écran 2022-05-20 à 08 49 57

Capture d’écran 2022-05-20 à 08 50 13

Only problem now is that private browsing is off, lol
I commend anybody who knows how to code XD

@fmeyertoens
Copy link
Contributor

Just to be sure, you only changed line 159 to: :root:-moz-any([lwtheme-brighttext], [privatebrowsingmode=temporary])?

@ghost
Copy link

ghost commented May 22, 2022

Just to be sure, you only changed line 159 to: :root:-moz-any([lwtheme-brighttext], [privatebrowsingmode=temporary])?

Someone has a good eye, I accidentally slashed the [privatebrowsingmode=temporary]), so apologies for the mixup, this is what it looks like now.
Capture d’écran 2022-05-22 à 13 53 56

@quarkquartet
Copy link

Just to be sure, you only changed line 159 to: :root:-moz-any([lwtheme-brighttext], [privatebrowsingmode=temporary])?

Someone has a good eye, I accidentally slashed the [privatebrowsingmode=temporary]), so apologies for the mixup, this is what it looks like now. Capture d’écran 2022-05-22 à 13 53 56

I think the current correct code should be:

:root:-moz-any([lwtheme-brighttext], [privatebrowsingmode=temporary])
{
	--toolbar-field-background-color: #202124 !important;
	--toolbar-field-hover-background-color: #292a2d !important;
	--toolbar-field-focus-background-color: #202124 !important;
}

It works perfect for me.

@missuo
Copy link

missuo commented May 28, 2022

Just to be sure, you only changed line 159 to: :root:-moz-any([lwtheme-brighttext], [privatebrowsingmode=temporary])?

Someone has a good eye, I accidentally slashed the [privatebrowsingmode=temporary]), so apologies for the mixup, this is what it looks like now. Capture d’écran 2022-05-22 à 13 53 56

I think the current correct code should be:

:root:-moz-any([lwtheme-brighttext], [privatebrowsingmode=temporary])
{
	--toolbar-field-background-color: #202124 !important;
	--toolbar-field-hover-background-color: #292a2d !important;
	--toolbar-field-focus-background-color: #202124 !important;
}

It works perfect for me.

58786c951d55b9343b314

This is almost perfect, but I think the URL could be a little darker in black in the Light theme.

@paralin
Copy link

paralin commented Jun 16, 2022

Thanks for the solutions: just to summarize to anyone reading this thread:

  1. Edit chrome/global/variables.css
  2. Go to line 159
  3. Replace it with :root:-moz-any([lwtheme-brighttext], [privatebrowsingmode=temporary])

paralin added a commit to paralin/MaterialFox that referenced this issue Jun 26, 2022
The URL bar and text are all white due to a CSS selector no longer
working as expected.

Fixes muckSponge#317

Signed-off-by: Christian Stewart <christian@paral.in>
@paralin paralin linked a pull request Jun 26, 2022 that will close this issue
M0kh added a commit to M0kh/MaterialFox-Updated that referenced this issue Aug 12, 2022
Added fix for the URL bar being completely white from muckSponge#317 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet