Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Address Text has incorrect vertical padding while focused after opening new tab. #324

Open
HomemadeToast57 opened this issue Jul 24, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@HomemadeToast57
Copy link

Sanity checks (must complete)

  • [Y] I have read and followed the installation instructions in the README
  • [Y] I have not modified the userChrome.css file
  • [Y] I have tested the latest release for my Firefox version, or commit on master/beta branch (beta is for Firefox Beta only)

Describe the bug
The vertical padding (specifically top padding) of the URL address text is incorrect within its container when you open or switch to a new tab and have focus on the search bar.

To Reproduce
Steps to reproduce the behavior:

  1. Install MaterialFox chrome folder and user.js to profile root directory
  2. Restart Firefox
  3. Open new tab or click on address bar -> switch tabs -> return back to original tab (make sure you are not in the focus mode where it shows you autocomplete suggestions list)

Screenshot
Screen Shot 2022-07-24 at 3 08 47 PM
System info

  • OS: MacOS
  • Firefox version: 103.0b9

Additional context
I have a fix. It's a one line change that I will PR momentarily.

@HomemadeToast57 HomemadeToast57 added the bug Something isn't working label Jul 24, 2022
@HomemadeToast57
Copy link
Author

Since the time I posted this issue, I have fixed the bug and submitted a pull request to fix this. The pull request can be found here: #325.

Screenshot AFTER fix
Look at the URL text inside the address bar...

Screen Shot 2022-07-24 at 3 34 29 PM

If you want to manually fix this and do not want to wait until they merge the pull request, change line #208 in chrome/urlbar/urlbar.css as shown below:

from
	padding: 0 !important;
to
	padding: 0 auto !important;

All this does is separates the horizontal and vertical padding and gives the top and bottom of the urlbar even padding (left and right padding is unchanged).

Hope this helps! :)

zhouhaibing089 added a commit to zhouhaibing089/MaterialFox-Plus that referenced this issue May 14, 2023
tab separator is again not working in new version of firefox. The whole
transform css rule probably can be removed, but in case this value needs another
adjustment, this is still kept around.

urlbar text misalignment can be fixed based on comment from [here][1]

[1]: muckSponge#324 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant