Skip to content

Commit

Permalink
Use File::PATH_SEPARATOR instead of : to fix Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
stanhu committed Jul 17, 2023
1 parent e084ceb commit a1a9ec6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions ext/re2/extconf.rb
Original file line number Diff line number Diff line change
Expand Up @@ -355,9 +355,9 @@ def build_with_vendored_libraries
pkg_config_paths = [
"#{abseil_recipe.path}/lib/pkgconfig",
"#{re2_recipe.path}/lib/pkgconfig"
].join(':')
].join(File::PATH_SEPARATOR)

pkg_config_paths = "#{ENV['PKG_CONFIG_PATH']}:#{pkg_config_paths}" if ENV['PKG_CONFIG_PATH']
pkg_config_paths = "#{ENV['PKG_CONFIG_PATH']}#{File::PATH_SEPARATOR}#{pkg_config_paths}" if ENV['PKG_CONFIG_PATH']

ENV['PKG_CONFIG_PATH'] = pkg_config_paths
pc_file = File.join(re2_recipe.path, 'lib', 'pkgconfig', 're2.pc')
Expand Down
2 changes: 1 addition & 1 deletion scripts/test-gem-build
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if [[ "${BUILD_NATIVE_GEM}" == "ruby" ]] ; then
bundle exec rake clean compile
bundle exec rake gem
else
bundle exec rake gem:${BUILD_NATIVE_GEM}
bundle exec rake gem:${BUILD_NATIVE_GEM}:builder
fi

mkdir -p ${OUTPUT_DIR}
Expand Down

0 comments on commit a1a9ec6

Please sign in to comment.