Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BH-1776] USB charging fixes #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wsad4ryba
Copy link

Device charging fix
Mudita-Harmony [2302B] by Grinn

Copy link
Contributor

@dawidwojtas-mudita dawidwojtas-mudita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! The code is well written.
Please take a look at a few minor remarks we left, mainly stylistic.

dcd/usb_phydcd.c Outdated Show resolved Hide resolved
dcd/usb_phydcd.c Outdated Show resolved Hide resolved
dcd/usb_phydcd.c Outdated Show resolved Hide resolved
dcd/usb_phydcd.c Outdated Show resolved Hide resolved
dcd/usb_phydcd.c Outdated Show resolved Hide resolved
dcd/usb_phydcd.c Outdated Show resolved Hide resolved
dcd/usb_phydcd.c Outdated Show resolved Hide resolved
dcd/usb_phydcd.c Outdated Show resolved Hide resolved
dcd/usb_phydcd.c Outdated Show resolved Hide resolved
dcd/usb_phydcd.c Outdated Show resolved Hide resolved
Copy link
Member

@Lefucjusz Lefucjusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, please change the title of the PR and corresponding commit so that it complies to the standard used in our company, which is [BH-xxx] What is introduced by this commit, where xxx is our internal tracking number. In case of this task this should be BH-1776, so the title would be something like [BH-1776] USB charging fixes.

@wsad4ryba wsad4ryba changed the title charging fix [BH-1776] USB charging fixes Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants