-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BH-1776] USB charging fixes #89
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! The code is well written.
Please take a look at a few minor remarks we left, mainly stylistic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, please change the title of the PR and corresponding commit so that it complies to the standard used in our company, which is [BH-xxx] What is introduced by this commit
, where xxx
is our internal tracking number. In case of this task this should be BH-1776
, so the title would be something like [BH-1776] USB charging fixes
.
Device charging fix
Mudita-Harmony [2302B] by Grinn