Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing DEBUG env var for docker compose #1128

Closed
wants to merge 2 commits into from
Closed

Exposing DEBUG env var for docker compose #1128

wants to merge 2 commits into from

Conversation

jamesbraza
Copy link
Contributor

Signed-off-by: James Braza <jamesbraza@gmail.com>
@lunamidori5 lunamidori5 self-requested a review October 3, 2023 18:18
Copy link
Collaborator

@lunamidori5 lunamidori5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already apart of the .env file, do we need it in two places at once or is this a bug fix?

@lunamidori5
Copy link
Collaborator

    env_file:
      - .env

This loads everything into the docker compose and passes it to the VM

Signed-off-by: James Braza <jamesbraza@gmail.com>
@jamesbraza
Copy link
Contributor Author

Good point, it's prolly better to have one correct route, not using multiple options. I moved to environment: [], which basically is a commented redirect to the .env file. Lmk what you think of that

@mudler
Copy link
Owner

mudler commented Oct 4, 2023

I'm not sure what's the addition here - isn't this already covered by env_file?

@jamesbraza
Copy link
Contributor Author

Yeah the story here is:

  1. I wanted to be able to do DEBUG=true docker compose up, so I started with dd9aed6 (#1128)
  2. Luna pointed out we have the .env file already hooked up, and I agree it's best to have one path
  3. So I made e36af42 (#1128) to basically make it clear which path to take (using .env file)

So this PR is sort of a no-op at the Docker level, but a human-level redirect. Also, feel free to close this out, as I am unsure if I think the change is really just user error

@lunamidori5
Copy link
Collaborator

Closing PR

@lunamidori5 lunamidori5 closed this Oct 4, 2023
@jamesbraza jamesbraza deleted the debug-docker-compose branch October 4, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants