-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat(ROCm): Allow selecting ROCm version when building llama.cpp backend #7615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sredman
wants to merge
23
commits into
mudler:master
Choose a base branch
from
sredman:work/sredman/rocm-version-control
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
9144c32
Add build arg for ROCm version
sredman 9849512
Break ROCM_VERSION into ROCM_{MAJOR,MINOR}_VERSION
sredman 22352b4
Use correct ROCm package names
sredman edd8c55
Add rocm package for runtime libs
sredman e709a73
Remove hipblas-dev and rocblas-dev. I think they are not needed, and …
sredman ab3bc75
Migrate ROCM build flags to llama-cpp docker file
sredman 216ae36
Change base-level Dockerfile back to same runtime dependency packages…
sredman a4ef661
Use default ROCm version of 5.5.1 to match Ubuntu package
sredman 54c5bb8
Remove ROCm runtime package from llamacpp dockerfile
sredman 9a11a07
Annotate ROCm runtime dependencies
sredman 7d95eab
Remove comments in runtime dependencies install step
sredman 517c7e6
Change default ROCM version to 6.4.3
sredman 54ed3e6
Rename ROCm6 build in image CI output to -gpu-amd-rocm-6
sredman 20117c4
Add ROCm 7 image builds
sredman 6e7fd30
Add rocm-*-version arguments to backend.yml header
sredman 94a1620
Change 'amd' capability to 'amd-rocm-'
sredman 88a3ced
Translate all backend index.yaml entries to use 'amd-rocm-6' instead …
sredman 9297568
Add backend/index.yaml entries for llama-cpp on rocm7
sredman 1a1af07
Update docker tags for previously mis-named backends
sredman 7ea4b73
Bulk update documentation with new image tag names
sredman 2043272
Add rocm version inputs to backend_build.yml
sredman 4aad63f
Align the default version in backend_build with the rest of the universe
sredman 63449eb
Fix merge conflict'd base-image
sredman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should actually add the new rocm arguments here: https://github.com/mudler/LocalAI/blob/master/.github/workflows/backend_build.yml#L15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure I understand this comment correctly. Do you mean simply add
rocm-*-versionaround L15 of backend_build.yaml? I have done that. If you mean something else, please guide me 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you did that change, It seems it's not been committed, in this changeset there are no changes to that file (
backend_build.yml) that is basically needed otherwise the CI won't pick up the options defined hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now this has truly been done 😄