feat: Add conditional unpacking support #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced build tags to enable or disable the unpack image functionality - Added a new file `unpack_image_disabled.go` to handle cases when unpacking is disabled - Updated existing files to accommodate the new build tag structure This allows yip consumers to not build the unpack plugin if desired which saves 1243kB of deps from the following deps: - github.com/google/go-containerregistry -> 512 kB - github.com/docker/docker -> 391 kB - go.opentelemetry.io/otel -> 340 kB Signed-off-by: Itxaka <itxaka@kairos.io>
Collaborator
|
Which consumer is going to skip unpack? I think at least kairos-agent depends on this functionality, I'm not sure about other consumers (immucore?) |
Collaborator
Author
yep, immucore is the main one but some other could benefit, like kairos-init I think which should skip the git and the unpack, although it doesnt hurt that much in that case as we dont ship init anywhere that it matters |
jimmykarily
approved these changes
Jan 9, 2026
Collaborator
jimmykarily
left a comment
jimmykarily
left a comment
There was a problem hiding this comment.
As long as default is "on" I'm good with it.
Collaborator
Author
it should, only if the tag is set while building it will change behavior. It should be otherwise transparent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unpack_image_disabled.goto handle cases when unpacking is disabledThis allows yip consumers to not build the unpack plugin if desired which saves 1243kB of deps from the following deps: