fixing STL internal error checks firing (in MSVC2019 builds at least) #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tialized vector iterator", "cannot seek vector iterator after end", std::isspace() on Windows does not cope well with UTF8 or rather `char` values > 127 as those will become *negative*, e.g. `-89` and trigger the validation checks in the MSVC debug library: for this the internal `txt` namespaced wrappers has been provided specifically... # Conflicts: # test/blocking_test09.cpp # test/blocking_test10.cpp # test/joined_params_test1.cpp # test/repeatable_alternatives_test.cpp # test/values_sequencing_test.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing STL internal error checks firing: "can't dereference value-initialized vector iterator", "cannot seek vector iterator after end".
Also fix:
std::isspace()on Windows does not cope well with UTF8 or rather more precise:charvalues > 127 as those will become negative in that 8-bitcharinteger type, e.g.-89and trigger the validation checks in the MSVC debug library, popping up yet another abort/retry/ignore debug report dialog box. For this the internaltxtnamespaced wrappers have been provided specifically...(cherrypicked off https://github.com/GerHobbelt/clipp master branch; original commit tested with latest MSVC2019)