Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing dots #22

Merged
merged 1 commit into from
Oct 26, 2018
Merged

fix missing dots #22

merged 1 commit into from
Oct 26, 2018

Conversation

Jnchk
Copy link
Contributor

@Jnchk Jnchk commented Oct 26, 2018

Package Testing of go 1.11 is more strict about arguments checking to print-like functions. We will get the error bellow if we left args without dots.

go test -v
# github.com/muesli/cache2go
./cachetable.go:330: missing ... in args forwarded to print-like function
FAIL    github.com/muesli/cache2go [build failed]

OS version:
manjaro 18.0.0-rc
go 1.11.1

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1a478e9 on Jnchk:fix-missing-dots into 5a18398 on muesli:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1a478e9 on Jnchk:fix-missing-dots into 5a18398 on muesli:master.

@muesli muesli merged commit 493cbf5 into muesli:master Oct 26, 2018
@muesli
Copy link
Owner

muesli commented Oct 26, 2018

Thank you for your contribution!

@Jnchk Jnchk deleted the fix-missing-dots branch October 26, 2018 14:36
Jnchk added a commit to Jnchk/cache2go that referenced this pull request Dec 21, 2018
Expand values for printing (muesli#22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants